fix: restrict Claude comment triggers to trusted repo actors#139
Merged
jmcte merged 1 commit intoJun 22, 2026
Merged
Conversation
athena-omt
approved these changes
Jun 22, 2026
athena-omt
left a comment
Contributor
There was a problem hiding this comment.
Athena review: approves. The change is focused, tests cover the new guard, and I don't see a blocker in the diff.
pheidon
approved these changes
Jun 22, 2026
pheidon
left a comment
Contributor
There was a problem hiding this comment.
Pheidon review: approves. The change is focused, tests cover the new guard, and I don't see a blocker in the diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@claude, and recent changes moved that job to the public self-hosted runner pool which exposes long-lived fleet credentials and secrets to untrusted actors.Description
.github/workflows/claude.ymlto requireauthor_associationto be one ofOWNER,MEMBER, orCOLLABORATORforissue_comment,pull_request_review_comment, andpull_request_reviewtriggers while keepingworkflow_dispatchintact.ifcondition now checkscontains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'), github.event...author_association)alongside the@claudebody checks.test/workflow.test.tsthat parses the workflow and asserts the new author-association guard and that untrusted association strings likeFIRST_TIME_CONTRIBUTOR,CONTRIBUTOR, andNONEare not present.Testing
pnpm test -- test/workflow.test.ts, and the test suite passed.pnpm lint(TypeScript--noEmit) and it completed successfully.claude.ymlcondition and verifies the presence of the author-association guards.Codex Task